Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes text_tracks breaking video edit view #276

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

Fixes #273

It seems text_tracks are not being returned if a video does not contain them. The video-edit template uses text_tracks. This PR gets it defined if it is not already returned by the API response.

Closes #

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@enrico-sorcinelli
Copy link

Thanks @oscarssanchez,
perhaps you should fix includes/admin/api/class-bc-admin-media-api.php too in order to avoid Invalid argument supplied for foreach() warning on line 1077.
Best regards

@oscarssanchez oscarssanchez merged commit 56087a1 into develop Jun 7, 2022
@oscarssanchez oscarssanchez deleted the hotfix/api-response branch June 7, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video edit screen seems no longer working
3 participants