Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: further optimize props to remove extra yoast data #560

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

nicholasio
Copy link
Member

@nicholasio nicholasio commented Jul 16, 2023

Description of the Change

Closes #559

How to test the Change

Compare the size of the next page data before and after this PR.

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2023

🦋 Changeset detected

Latest commit: 68bf7e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@headstartwp/core Patch
@headstartwp/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2023 5:50pm

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 8.05 KB 128.43 KB 88.57% (🟡 +0.02%)
/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/author/[...path] 4.58 KB 124.96 KB 86.18% (🟡 +0.01%)
/blog/[[...path]] 4.83 KB 125.21 KB 86.35% (🟡 +0.02%)
/book/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/books/[[...path]] 4.34 KB 124.72 KB 86.01% (🟡 +0.02%)
/category/[...path] 4.75 KB 125.13 KB 86.30% (🟡 +0.01%)
/search/[[...path]] 4.16 KB 124.54 KB 85.89% (🟡 +0.01%)
/tag/[...path] 4.78 KB 125.16 KB 86.31% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 8.05 KB 128.43 KB 88.57% (🟡 +0.02%)
/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/author/[...path] 4.58 KB 124.96 KB 86.18% (🟡 +0.01%)
/blog/[[...path]] 4.83 KB 125.21 KB 86.35% (🟡 +0.02%)
/book/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/books/[[...path]] 4.34 KB 124.72 KB 86.01% (🟡 +0.02%)
/category/[...path] 4.75 KB 125.13 KB 86.30% (🟡 +0.01%)
/search/[[...path]] 4.16 KB 124.54 KB 85.89% (🟡 +0.01%)
/tag/[...path] 4.78 KB 125.16 KB 86.31% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 8.05 KB 128.43 KB 88.57% (🟡 +0.02%)
/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/author/[...path] 4.58 KB 124.96 KB 86.18% (🟡 +0.01%)
/blog/[[...path]] 4.83 KB 125.21 KB 86.35% (🟡 +0.02%)
/book/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/books/[[...path]] 4.34 KB 124.72 KB 86.01% (🟡 +0.02%)
/category/[...path] 4.75 KB 125.13 KB 86.30% (🟡 +0.01%)
/search/[[...path]] 4.16 KB 124.54 KB 85.89% (🟡 +0.01%)
/tag/[...path] 4.78 KB 125.16 KB 86.31% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 8.05 KB 128.43 KB 88.57% (🟡 +0.02%)
/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/author/[...path] 4.58 KB 124.96 KB 86.18% (🟡 +0.01%)
/blog/[[...path]] 4.83 KB 125.21 KB 86.35% (🟡 +0.02%)
/book/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/books/[[...path]] 4.34 KB 124.72 KB 86.01% (🟡 +0.02%)
/category/[...path] 4.75 KB 125.13 KB 86.30% (🟡 +0.01%)
/search/[[...path]] 4.16 KB 124.54 KB 85.89% (🟡 +0.01%)
/tag/[...path] 4.78 KB 125.16 KB 86.31% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/ 8.05 KB 128.43 KB 88.57% (🟡 +0.02%)
/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/author/[...path] 4.58 KB 124.96 KB 86.18% (🟡 +0.01%)
/blog/[[...path]] 4.83 KB 125.21 KB 86.35% (🟡 +0.02%)
/book/[...path] 5.71 KB 126.09 KB 86.96% (🟡 +0.01%)
/books/[[...path]] 4.34 KB 124.72 KB 86.01% (🟡 +0.02%)
/category/[...path] 4.75 KB 125.13 KB 86.30% (🟡 +0.01%)
/search/[[...path]] 4.16 KB 124.54 KB 85.89% (🟡 +0.01%)
/tag/[...path] 4.78 KB 125.16 KB 86.31% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@nicholasio nicholasio merged commit 1494a33 into develop Jul 17, 2023
6 checks passed
@nicholasio nicholasio deleted the feature/optimize-yoast branch July 17, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yoast data in usePosts() response blowing up the data 10x
1 participant