Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work on Node LTS #22

Closed
wants to merge 2 commits into from
Closed

Conversation

allmarkedup
Copy link

@allmarkedup allmarkedup commented Jul 15, 2024

Addresses the issues discussed in #17.

I tried running @LewisDaleUK's PR (#14) which attempts the same thing but had a few issues for me (bundle size and timeouts).

As in the previous PR this updates puppeteer-core and replaces chrome-aws-lambda with @sparticuz/chromium and additionally:

Which from my testing fixes the bundle size and other issues in #14.


Example screenshot (from my instance running on Netlify): https://11ty-api-screenshot-fix.netlify.app/https%3A%2F%2Fwww.11ty.dev%2Fdocs%2F/small/9:16/bigger/

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for eleventy-api-screenshot failed.

Name Link
🔨 Latest commit 1604b8d
🔍 Latest deploy log https://app.netlify.com/sites/eleventy-api-screenshot/deploys/66950ca2957e7100081ad80c

zachleat added a commit that referenced this pull request Jul 18, 2024
@zachleat
Copy link
Member

Thank you! The code changes were a little noisy so I merged some of the changes externally.

Note also the comment here as the production service is now running on Vercel: #14 (comment)

I’d consider this v1-netlify branch to be deprecated but I’m happy to continue merging PRs to it if folks want to help maintain it.

@zachleat zachleat closed this Jul 18, 2024
@allmarkedup
Copy link
Author

Sounds good! Thanks for your work on this @zachleat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants