-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render CLI Shell plugin #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
I left some guidance, I'd love if you could address the remaining TODOs, before the next round of review. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my suggestions!
I see that this submission currently contains two plugins: deta
and render
. Let's move the former in a separate PR.
Hello! Is this a submission for the 1Password Hackathon with Hashnode? If so, when you're ready, please be sure you write a blog post on Hashnode to make your submission official. Full instructions are on the Hackathon page. |
It's an entry, i want to write one article for all my contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving in the right direction! Love it 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look over the test suite and lint - I left one indication over how to start. 😄
Also, could you please sign your commits? The trace of the Github Action ("Check signed commits in PR") should provide a good indication of how to do so. |
You can validate your tests to pass by running Do let me know if you need any help to make the pipelines ✅ . |
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
Signed-off-by: Smyja <akposlive59@gmail.com>
I have signed the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great!
I did NOT functionally test this, as I'm having some trouble currently with my local builds, so I'd love if @arunsathiya or @AndyTitu could take a look here.
Approving for the code.
Files: map[string]sdk.OutputFile{ | ||
"~/.render/config.yaml": { | ||
Contents: []byte(plugintest.LoadFixture(t, "config.yaml") + "\n"), | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a newline directly to the file, shall we?
great, can you change the label status? |
@smyja I'll leave it like this, until we get a functional testing too. Then we can proceed to the security review, when I will be changing the label. 😄 |
@smyja could you possible provide a video/image in which you test that this plugin works as expected for the The steps to test are:
|
Overview
Type of change
How To Test
Changelog