-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CrateDB Shell Plugin #313
base: main
Are you sure you want to change the base?
Conversation
Hello! Is this a submission for the 1Password Hackathon with Hashnode? If so, when you're ready, please be sure you write a blog post on Hashnode to make your submission official. Full instructions are on the Hackathon page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @parthiv11 ! Thank you for your contribution, this plugin looks really neat already! I have suggested a few small improvements, but I feel we are on the right track with this PR. Feel free to get it out of draft!
@hculea is that ok |
@AndyTitu is this ok? |
I think this should to labeled for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parthiv11 Thank you for the good work! I think this is almost ready. I only have 1 more comment.
Before I can approve this, I'd like to see a quick video/screenshot of this plugin working, if that's okay.
Thank you!
video_20230712_231219_edit.mp4It is working now 👍👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR lgtm but I had some last remarks. I will approve proactively as I think this is good to go after my latest comments are addressed.
import ( | ||
"testing" | ||
|
||
"github.com/1Password/shell-plugins/sdk" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter is complaining that this file is not formatted, and more specifically these imports are not in order.
Hi @parthiv11, the test case you've added is failing. Could you please give that a look? Before we can merge your changes, you'll also need to sign your commits. You can follow the instructions below to sign your commits.
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
Overview
Added basic implementation of CrateDB using CRATEPW env Variable
Created a new plugin
Improved an existing plugin
Fixed a bug in an existing plugin
Improved contributor utilities or experience
Related Issue(s)
How To Test
Changelog