Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CrateDB Shell Plugin #313

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

parthiv11
Copy link
Contributor

Overview

  • Added basic implementation of CrateDB using CRATEPW env Variable

  • Created a new plugin

  • Improved an existing plugin

  • Fixed a bug in an existing plugin

  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

Changelog

@AndyTitu AndyTitu added the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Jun 26, 2023
@techcraver
Copy link
Contributor

techcraver commented Jun 26, 2023

Hello! Is this a submission for the 1Password Hackathon with Hashnode? If so, when you're ready, please be sure you write a blog post on Hashnode to make your submission official. Full instructions are on the Hackathon page.

Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @parthiv11 ! Thank you for your contribution, this plugin looks really neat already! I have suggested a few small improvements, but I feel we are on the right track with this PR. Feel free to get it out of draft!

plugins/cratedb/database_credentials.go Outdated Show resolved Hide resolved
plugins/cratedb/database_credentials.go Outdated Show resolved Hide resolved
plugins/cratedb/database_credentials.go Outdated Show resolved Hide resolved
plugins/cratedb/database_credentials.go Outdated Show resolved Hide resolved
@AndyTitu AndyTitu added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jun 27, 2023
@parthiv11 parthiv11 marked this pull request as ready for review June 27, 2023 13:12
plugins/cratedb/database_credentials.go Outdated Show resolved Hide resolved
plugins/cratedb/provisioner.go Outdated Show resolved Hide resolved
plugins/cratedb/provisioner.go Outdated Show resolved Hide resolved
plugins/cratedb/database_credentials.go Outdated Show resolved Hide resolved
@parthiv11
Copy link
Contributor Author

@hculea is that ok

@parthiv11
Copy link
Contributor Author

@AndyTitu is this ok?

@parthiv11
Copy link
Contributor Author

I think this should to labeled for hashnode hackathon

@arunsathiya arunsathiya added the hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th label Jul 3, 2023
Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthiv11 Thank you for the good work! I think this is almost ready. I only have 1 more comment.

Before I can approve this, I'd like to see a quick video/screenshot of this plugin working, if that's okay.
Thank you!

@hculea hculea requested a review from AndyTitu July 5, 2023 07:35
@parthiv11
Copy link
Contributor Author

parthiv11 commented Jul 12, 2023

video_20230712_231219_edit.mp4

It is working now 👍👍

Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR lgtm but I had some last remarks. I will approve proactively as I think this is good to go after my latest comments are addressed.

plugins/cratedb/provisioner.go Outdated Show resolved Hide resolved
import (
"testing"

"github.com/1Password/shell-plugins/sdk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is complaining that this file is not formatted, and more specifically these imports are not in order.

plugins/cratedb/provisioner.go Outdated Show resolved Hide resolved
plugins/cratedb/provisioner.go Outdated Show resolved Hide resolved
@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jul 24, 2023
@AndyTitu AndyTitu added waiting-on-sec-review and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Aug 30, 2023
@SimonBarendse
Copy link
Member

Hi @parthiv11, the test case you've added is failing. Could you please give that a look?

Before we can merge your changes, you'll also need to sign your commits. You can follow the instructions below to sign your commits.


⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

Let us know if you have any questions or run into issues signing your commits. We're here to help.

@SimonBarendse SimonBarendse added the in-progress this PR is being worked on/comments are in the process of being addressed by the contributor label Sep 22, 2023
@accraw accraw mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th in-progress this PR is being worked on/comments are in the process of being addressed by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants