Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ipinfo CLI #339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rajapri28613
Copy link
Contributor

Overview

Add support for ipinfo CLI. The shell plugin provisions a configuration file at ~/Library/Application\ Support/ipinfo/config.json. The shell plugin also imports the Token from the same file at the same path, if it exists.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  • Install ipinfo CLI and set up shell plugin.
  • Run a bulk query like ipinfo bulk 8.8.8.0-8.8.8.255 1.1.1.0/30 123.123.123.123 and it'll use the token for queries. Bulk queries cannot be run without a token.

Changelog

Add support for ipinfo CLI.

Additional information

@rajapri28613
Copy link
Contributor Author

@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th labels Jul 3, 2023
@hculea hculea requested review from arunsathiya and AndyTitu and removed request for arunsathiya July 5, 2023 07:31
@accraw
Copy link
Contributor

accraw commented Jul 26, 2023

When I run your test command (ipinfo bulk 8.8.8.0-8.8.8.255 1.1.1.0/30 123.123.123.123) without the shell plugin it works, but after setting up the shell plugin it just hangs. Were you able to get it to run successfully?

@AndyTitu
Copy link
Contributor

@rajapri28613 could you share a video of in which this shell plugin is working as expected?

but after setting up the shell plugin it just hangs.

This makes me think that the TempFile approach might not be suitable for this plugin

@AndyTitu AndyTitu added question Further information is requested and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants