Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Auto-add one approval to automated flake.lock PRs #456

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

mrjones2014
Copy link
Member

@mrjones2014 mrjones2014 commented Apr 19, 2024

Overview

Makes the github-actions[bot] automatically approve its own automated flake.lock update PRs. The PRs will still require 1 manual human approval, but only requiring 1 human approval helps us keep up with it, and there is reduced risk with these PRs vs. dependabot PRs for example, since we're only pulling in flake-utils and nixpkgs which are already screened by their respective maintainers.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

How To Test

TODO I'm not sure how exactly to test this other than merging it to main and running a new flake.lock automation job to see if this applies correctly to it. @AndyTitu any ideas?

Changelog

Update flake.lock automation to reduce maintenance burden.

@mrjones2014
Copy link
Member Author

@mrjones2014
Copy link
Member Author

A little bit more explanation: I also scoped this down to help further ensure that these auto-approvals only apply to the flake.lock automated PRs by updating the original job to add a label flake.lock automation to the flake.lock update PRs, and then this new PR approval job only runs if:

  • PR author is github-actions[bot]
  • AND the PR has the flake.lock automation label

Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! ❤️

@mrjones2014 mrjones2014 merged commit 3fae904 into main Apr 19, 2024
5 checks passed
@mrjones2014 mrjones2014 deleted the mrj/452/flake-ci-updates branch April 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-flake-dependencies job fails if the previous automated PR isn't merged
3 participants