Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted ErrorBoundary to functional component #404

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

converted ErrorBoundary to functional component #404

wants to merge 2 commits into from

Conversation

patrick-1upHealth
Copy link

@patrick-1upHealth patrick-1upHealth commented Apr 12, 2023 •
edited
Loading

Issue:
#399

PR Checklist
  • Give this PR a meaningful title
  • Add a link to the related issue at the top of this description (above)
  • Ensure your branch is up to date with the target branch and resolve any conflicts
  • Answer the below questions to describe your PR for reviewers

Why are these changes needed?

Part of updating all of our components away from class components to all functional components.

What changed?

  • Converted ErrorBoundary to functional component
  • Replaced componentDidCatch with a try...catch... in ErrorBoundary

How are these changes tested?

  • Run storybook and see that there are no errors in the tested components

@patrick-1upHealth
converted fhirResource and ErrorBoundary to functional components, tr…
68dc9c1 
…ied using try catch approach to fix ErrorBoundary
This was referenced Apr 12, 2023
Open
Open
@patrick-1upHealth patrick-1upHealth changed the title converted fhirResource and ErrorBoundary to functional components, tr… converted ErrorBoundary to functional component Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jocelynn1uphealth jocelynn1uphealth Awaiting requested review from jocelynn1uphealth

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@patrick-1upHealth