API refactor #851
Open
API refactor #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In hindsight this makes an awful lot of sense. |
Avoid device-specific memory things in the main library
I'd prefer to not allocate 2k of RAM for something that is mostly constants. The STM32 parts are somewhat hacky
Might be usable in global initialisers... still undefined though.
Not needed elsewhere. Reduces RAM usage for the API to 64 bytes
These patches predate it, so add it to squash the warnings.
Daft-Freak
force-pushed
the
api-refactor
branch
from
1f065cf
to
8dfbbf3
Compare
Same as the pico patch
|
Fixed warnings from these patches being older than I'll have to add the STM32 nastiness to the list of things that can be cleaned up if there's an API break... (Also, I should actually write that list) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the API struct into a "const" and "data" part. This is a result of me not wanting to reserve 2K of RAM on pico. After this, all the function pointers can be constants (may improve #484) and the data part only needs 64 bytes.
For compatibility, 32blit-stm32 is still using the old layout by inserting padding and overlaying the two structs on top of each other.
These are (I think) the only remaining non-pico changes on my big pico branch.