Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal scan button: Step 2 - Allow scanning of recipient addresses #272

Closed
tschubotz opened this issue Nov 19, 2019 · 1 comment
Closed

Comments

@tschubotz
Copy link
Member

What is this feature about? (1 sentence)

This feature will allow users to scan ethereum address QR codes with the universal scan button.

Why is it needed? What is the value? For whom do we build it?

High-level overview of the feature

  • User can scan ethereum QR codes.
  • The user ends up on the screen where their enter amount and select the asset.
  • This changes the send flow a bit since the user can switch the asset after selecting the recipient

Misc

Designs for this are worked on in #255

@tschubotz tschubotz added this to the Winter 19/20 ☃️🔥 milestone Nov 19, 2019
@tschubotz tschubotz added the Epic label Nov 19, 2019
@DmitryBespalov
Copy link
Contributor

DmitryBespalov commented Dec 5, 2019

The QR-code formats that we want to recognize:

  • ERC-67: Standard URI scheme
  • ERC-681: URL format for Transaction Requests (supersedes ERC-67 with backward compatibility)
    • ERC-831: URI Format for Ethereum (needed by ERC-681)
    • ERC-137: ENS (for syntax of ENS names). I'd argue to support ENS_NAME as per the ERC-681, so that you could recognize a link with your ens name, too.
  • just a hex value: 0xabcdef...fedcba
  • or an ens name: something.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants