-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal scan button / make WalletConnect more prominent #255
Comments
Changes after discussion on Slack. What's been done:
This requires changing camera screens, at least adding instructions on what to scan. Some ideas for camera were discussed here https://app.zenhub.com/workspaces/gnosis-safe-5c1b98250e13551e8aae81eb/issues/gnosis/safe/190 |
Changes after WalletConnect meeting (https://docs.google.com/document/d/1WM09JrD417_6RinmDh0SYMtw1f_GGhHaLbca8buV2c8/edit#heading=h.il5khvo9jrqc). What's been done: Removed fiat values for now. Explored WalletConnect logo and "scan" icon instead of "camera" icon: iOS: https://invis.io/PEPL75H7ZV6#/394104596_AssetView_-WalletConnect_Icon-_ Android: https://invis.io/5JQJD5ZX7MF#/394108187_AssetView_-WalletConnect_Icon-_ |
good |
Thanks for the update. 2 questions that @rmeissner brought up. (1) When tapping the FAB for the first time, should we show the WalletConnect intro screens? I would say yes. And then let the user go straight to the camera. (2) After successfully connecting to a WalletConnect session initiated via the FAB, where should the user end up? (Currently they end up on the list of sessions). I'm undecided here. How about a success alert with a message that they can see all sessions ins settings? |
I prefer the scanner icon too. For (2) i would send him to the session list on android Edit: @posthnikova the invision links for android are both for the wallet connect icon |
@tschubotz I think we should. When entering WalletConnect from the Menu as well, whichever comes first. At the second step (when there would be scanning recipients addresses) we won't be showing specific WalletConnect slides. Maybe some educational slides on what to scan.
List of sessions is fine. Maybe without "Scan" button since "Back" button could also lead to Camera since it's the screen they came from. |
I would not send the user back to the camera. If he goes back he should be on the home screen again in my opinion |
UX sync: mention WalletConnect on Camera screen, show error popup when scanning regular address, WalletConnect logo for the 1st step. |
UX sync: show onboarding slides, Back button leads to Assets, don't show sessions list. |
@posthnikova I'll need the following assets:
|
Screens are on zeplin: iOS Overview: https://app.zeplin.io/project/5c49ce9866e3b3bee966f431/dashboard?seid=5c4f22a250e77937af4b0e9b iOS new Camera screen: https://zpl.io/2vOrD35 iOS QR code error: https://zpl.io/bJ09Y5J Android Overview: https://app.zeplin.io/project/5af063c9b4dc859b6bdaf897/dashboard?seid=5c41c8bc4def2a015b85322f Android new Camera screen: https://zpl.io/bzq0J47 Android QR code error: https://zpl.io/bzRA5Yl |
Please see epic for details
The text was updated successfully, but these errors were encountered: