Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

[iOS] Universal scan button Step 1: WalletConnect #1336

Closed
DmitryBespalov opened this issue Dec 2, 2019 · 1 comment
Closed

[iOS] Universal scan button Step 1: WalletConnect #1336

DmitryBespalov opened this issue Dec 2, 2019 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@DmitryBespalov
Copy link
Contributor

DmitryBespalov commented Dec 2, 2019

Epic

5afe/safe#254

Design

5afe/safe#255

Flow

  1. Press the button
  2. If first time
    1. Show onboarding
    2. Back button dismisses the screen (go back to AssetView)
  3. Scanner Opens
    1. If scanned non-wallet connect code, show error pop-up
      4. On scan success do not show session list - dismiss and show AssetView
  4. On scan success we show session list

UI changes

  1. Overlay button on top of the AssetView and Transaction View (basically on the Main screen)
  2. Scanner View
    1. Add explanation text
    2. Add Overlay with a frame
    3. Change the cancel button asset

Code Changes

  • WalletConnectFlowCoordinator
    • Have a new mode/flag that makes different behavior if opened from the scan button
      • Show onboarding
      • After scan finished - just dismiss the view (pop)
    • If scan opened from the sessions list - the old behavior holds.
  • New UI button appears on the MainViewController
  • ScannerViewController
    • New “WalletConnect” mode

Localization Strings

  • Scan the desktop Dapp’s QR code — for the WalletConnect scan mode
  • The scanned QR code is not a WalletConnect code. Please try again.
  • Scan the recipient’s QR code — for the Address input scan mode
  • Scan the Gnosis Authenticator QR code — for the Authenticator input code mode

Tracking Events

  • WalletConnect_OpenFromScanButton - when pressed the “Scan” button
@DmitryBespalov
Copy link
Contributor Author

@MouazAlzahabi I updated the "Flow" part

MouazAlzahabi pushed a commit that referenced this issue Dec 18, 2019
Fix pull request comments.
MouazAlzahabi pushed a commit that referenced this issue Dec 18, 2019
Show scanner header when present QRScanner from universal click
MouazAlzahabi pushed a commit that referenced this issue Dec 18, 2019
Fix pull request comments
MouazAlzahabi pushed a commit that referenced this issue Dec 18, 2019
Add unit testing
DmitryBespalov pushed a commit that referenced this issue Dec 19, 2019
…utton

Feature/gh 1336 universal scan button
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants