Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFI: Add comment for song arrangement #182

Closed
BiKi05 opened this issue Nov 18, 2023 · 4 comments
Closed

SFI: Add comment for song arrangement #182

BiKi05 opened this issue Nov 18, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@BiKi05
Copy link
Contributor

BiKi05 commented Nov 18, 2023

There is the possibility to add comments to song arrangements, we would like to have this comments in the API interface.

Unfortunately the comment cannot be requested by the Rest-API, only via the old AJAX API (not documented, only found via browser debugging):
https://xxx.church.tools/?q=churchservice/ajax&func=getComments&domain_type=arrangement&domain_id=<arrangement_id>

Would be great if you add this to your code.

@DumbergerL DumbergerL added the enhancement New feature or request label Nov 20, 2023
@BiKi05
Copy link
Contributor Author

BiKi05 commented Nov 20, 2023

Additional comment/explanation:

Actually we want to have a comment (globally) for a song and not only for an arrangement, but this is not possible in Churchtools. There is a database field which cannot be set via browser or API, see https://forum.church.tools/topic/9841/bemerkung-zu-song

So we use the comments at the arragement as workaroud - I know, there is the possibility to set a comment on an arrangement and read via API, but our users always use the comment function, as it is more easy to find/use.

DumbergerL added a commit that referenced this issue Dec 11, 2023
…ement

feat(song-arrangement-comment): retrieve, update and delete song-arrangement comments #182
@DumbergerL
Copy link
Contributor

@BiKi05 I implemented the feature in the PR #187 You can get more detailed information on how to use this feature in the docs: https://github.com/5pm-HDH/churchtools-api/blob/master/docs/out/SongAPI.md#retrieve-create-and-delete-comments

Sorry, it took so long.

@BiKi05
Copy link
Contributor Author

BiKi05 commented Dec 11, 2023

@DumbergerL Big thanks! I will test and integrate it soon.

@DumbergerL
Copy link
Contributor

Update August 2024:

Churchtools replaced the AJAX Api with a REST Endpoint: https://github.com/5pm-HDH/churchtools-api/blob/master/docs/out/SongAPI.md#create-song-arrangement-notes

New implementation: NoteRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants