Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use query parameters in GET requests for filtering #106

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

stollr
Copy link
Collaborator

@stollr stollr commented Sep 10, 2022

currently this is done with json/body params. It is working, because guzzle magically turns body params into query params when doing GET requests, but imho this is not clean and we should not rely on this behaviour.

currently this is done with json/body params. It is working, because guzzle magically turns body params into query params when doing GET requests, but this is not clean and we should not rely on this behaviour.
@DumbergerL
Copy link
Contributor

I have some Integration-Tests that are failing with the changes. It is probably just a thing with my data-constelation but i dont have time right now to check.
grafik
I hope i can review this PR in depth next week.

@DumbergerL
Copy link
Contributor

DumbergerL commented Sep 12, 2022

PermissionRequestTest:

  • fixed data in testata.ini

PublicGroupRequestTest:

PersonUpdateRequestTest:
Response for this Integration Test:

{
  "message": "Forbidden to edit the field statusId",
  "translatedMessage": "Keine Berechtigung um das Feld statusId zu sehen oder zu editieren",
  "messageKey": "error.forbidden.edit.field",
  "args": {
    "field": "statusId"
  },
  "errors": []
}

Error will be fixed in #108

@DumbergerL DumbergerL merged commit 907cb5b into 5pm-HDH:master Sep 12, 2022
@stollr stollr deleted the fix_request_filter branch October 6, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants