Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with PHPUnit test paths on linux #181

Closed
wants to merge 8 commits into from

Conversation

devdot
Copy link
Contributor

@devdot devdot commented Nov 4, 2023

First of all, thank you @DumbergerL for all the work you've put in with 2.0! It's looking great!

It seems like calling PHPUnit fails (at least on Linux), because phpunit.xml still has the lowercase directory names instead of the ones you've changed in #165. Perhaps it didn't fail on Windows because directories there are often treated case-insensitive (I didn't validate that however). It's a good step to make tests PSR-4 compliant though!

I wondered why PHPUnit didn't fail in CI and saw that for some reason it doesn't throw an error in Github Actions, but it says "No tests executed!". Perhaps PHPUnit could be setup to fail when no tests are executed? https://github.com/5pm-HDH/churchtools-api/actions/runs/6744038583/job/18333071116

@devdot
Copy link
Contributor Author

devdot commented Nov 4, 2023

Seems like the integration CI is broken and I'm not sure why. It seems like it's looking in the right place for the injected .ini but the credentials are not there:

class IntegrationTestData
{
private static $FILE_DIR = __DIR__ . '/integration-test-data.json';
private static $CREDENTIALS_FILE = __DIR__ . '/integration.ini';

@DumbergerL
Copy link
Contributor

I can't understand the behavior of the github-actions pipelines 100%. When I push commits to this PR, the credentials file obtained from the github secrets is empty. As soon as I push the commits to a new branch and create a fresh pr, the pipeline runs through and this PR also turns green.

I close this PR. All changes are continued on pr #186 .

@DumbergerL DumbergerL closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants