Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove jQuery from lib folder, replace with CDN #771

Merged
merged 1 commit into from
May 13, 2023
Merged

chore: remove jQuery from lib folder, replace with CDN #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/example-autocomplete-editor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<link rel="shortcut icon" type="image/ico" href="favicon.ico" />
<title>SlickGrid example: jQueryUI 'Autocomplete' javascript editor</title>
<link rel="stylesheet" href="../slick.grid.css" type="text/css"/>
<link rel="stylesheet" href="../css/smoothness/jquery-ui.css" type="text/css"/>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/themes/smoothness/jquery-ui.min.css" />
<link rel="stylesheet" href="examples.css" type="text/css"/>
</head>
<body>
Expand Down Expand Up @@ -34,8 +34,8 @@ <h2>View Source:</h2>

<script src="../lib/firebugx.js"></script>

<script src="../lib/jquery-3.1.0.js"></script>
<script src="../lib/jquery-ui.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.0/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/jquery-ui.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/sortablejs/Sortable.min.js"></script>

<script src="../slick.core.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion examples/example-composite-editor-item-details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ <h2>View Source:</h2>

<script src="../lib/firebugx.js"></script>

<script src="../lib/jquery-3.1.0.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.0/jquery.min.js"></script>
<script src="../lib/jquery.tmpl.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/flatpickr"></script>
<script src="https://cdn.jsdelivr.net/npm/sortablejs/Sortable.min.js"></script>
Expand Down
62 changes: 31 additions & 31 deletions examples/example-dynamic-filtered-with-jquery-tabs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<title>SlickGrid example: jQuery tabs with a dynamic filtered grid in each pane</title>
<link rel="stylesheet" href="../slick.grid.css" type="text/css"/>
<link rel="stylesheet" href="../controls/slick.pager.css" type="text/css"/>
<link rel="stylesheet" href="../css/smoothness/jquery-ui.css" type="text/css"/>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/themes/smoothness/jquery-ui.min.css" />
<link rel="stylesheet" href="examples.css" type="text/css"/>
<link rel="stylesheet" href="../controls/slick.columnpicker.css" type="text/css"/>
<style>
Expand All @@ -15,7 +15,7 @@
outline: 0;
border: 1px solid gray;
}

.cell-title {
font-weight: bold;
}
Expand Down Expand Up @@ -50,7 +50,7 @@
<div id="tabs-1">
<div><strong><i>This tab is the original</i></strong></div>
<br/>

<b>Search:</b>
<hr/>
<div style="padding:6px;">
Expand Down Expand Up @@ -86,8 +86,8 @@ <h2>View Source:</h2>

<script src="../lib/firebugx.js"></script>

<script src="../lib/jquery-3.1.0.js"></script>
<script src="../lib/jquery-ui.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.0/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/jquery-ui.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/sortablejs/Sortable.min.js"></script>

<script src="../slick.core.js"></script>
Expand All @@ -108,53 +108,53 @@ <h2>View Source:</h2>
var sliderElementName = "pcSlider_";
var searchElementName = "txtSearch_";
var selectButtonElementName = "btnSelectRows_";

var gridArray;
var dataViewArray;

// -----------------------------------------------------------------------------------
// HANDY HINTS
//
// There are many ways to achieve dynamic grids. The approach used in this example is
// to declare arrays for all the grid housekeeping objects such as search text, sort
// to declare arrays for all the grid housekeeping objects such as search text, sort
// direction etc, and for all the important objects such as grids and dataViews.
// In a single-grid page, these are usually variables, but for multiple grid pages,
// declaring an array allows us to keep a set of data for each grid indexed by the
// In a single-grid page, these are usually variables, but for multiple grid pages,
// declaring an array allows us to keep a set of data for each grid indexed by the
// 'gridIndex' from 1 to n.
// Events are declared once within the function that creates the grid, with the grid,
// dataview and gridIndex local vars being used to force a closure and lock the event
// Events are declared once within the function that creates the grid, with the grid,
// dataview and gridIndex local vars being used to force a closure and lock the event
// to that grid/dataView.
//
// Another approach would be to create single events used by all grids that can
// determine which grid they are associated with and respond accordingly.
// To facilitate this, all grid events pass the args.grid parameter which is the
// To facilitate this, all grid events pass the args.grid parameter which is the
// grid itself, and all dataView events pass the args.dataView parameter similarly.
//
// Where the grid is available and you want the dataView, use grid.getData().
// Where the dataView is available and you want the grid, use GetDataViewIndex()
// and reference the grid using gridArray[gridIndex].
//
// Getting the gridIndex from the grid or dataView also allows reference to the arrays
// Getting the gridIndex from the grid or dataView also allows reference to the arrays
// of housekeeping objects discussed earlier, and makes it easy get a handle on a control
// in the grid's tab by constructing element ids eg. sliderElementName above.
// The two following functions are not used in this page, but have been tested and can be

// The two following functions are not used in this page, but have been tested and can be
// utilised as just described to get the gridIndex from the grid or dataView object.
function GetGridIndex(grid) {
for (var i=1; i<gridArray.length; i++) {
if (gridArray[i] === grid) { return i; }
}
return -1;
}

function GetDataViewIndex(dataView) {
for (var i=1; i<dataViewArray.length; i++) {
if (dataViewArray[i] === dataView) { return i; }
}
return -1;
}
// -----------------------------------------------------------------------------------

var sortcolArray = [];
var sortdirArray = [];
var percentCompleteThresholdArray = [];
Expand Down Expand Up @@ -225,7 +225,7 @@ <h2>View Source:</h2>
d["finish"] = "01/05/2009";
d["effortDriven"] = (i % 5 == 0);
}

dataView.beginUpdate();
dataView.setItems(data);
dataView.setFilterArgs({
Expand All @@ -235,14 +235,14 @@ <h2>View Source:</h2>
dataView.setFilter(myFilter);
dataView.endUpdate();
}

function CreateGrid(gridIndex) {
if (!gridArray) { gridArray = []; dataViewArray=[]; }

// define element names
var gridId = gridElementName + gridIndex;
var pagerId = pagerElementName + gridIndex;

// create grid and associated components
var dataView = new Slick.Data.DataView({ inlineFilters: true });
var columns = CreateColumns();
Expand All @@ -252,24 +252,24 @@ <h2>View Source:</h2>

var pager = new Slick.Controls.Pager(dataView, grid, $("#" + pagerId));
var columnpicker = new Slick.Controls.ColumnPicker(columns, grid, options);

gridArray[gridIndex] = grid;
dataViewArray[gridIndex] = dataView;

// init arrays
sortcolArray[gridIndex] = "title";
sortdirArray[gridIndex] = 1;
percentCompleteThresholdArray[gridIndex] = 0;
searchStringArray[gridIndex] = "";
h_runfiltersArray[gridIndex] = null;
// wire up events. any reference to gridIndex creates a closure and locks

// wire up events. any reference to gridIndex creates a closure and locks
// the function to the current grid
function comparer(a, b) {
var x = a[sortcolArray[gridIndex]], y = b[sortcolArray[gridIndex]];
return (x == y ? 0 : (x > y ? 1 : -1));
}

grid.onCellChange.subscribe(function (e, args) {
dataView.updateItem(args.item.id, args.item);
});
Expand Down Expand Up @@ -401,11 +401,11 @@ <h2>View Source:</h2>
// or being on a different page) to stay selected, pass 'false' to the second arg
dataView.syncGridSelection(grid, true);
}

$(function () {
// take care of jqueryui tabs and adding tab
$( "div#tabs" ).tabs();
$( "div#tabs" ).tabs();

$("button#add-tab").click(function() {
var num_tabs = $("div#tabs ul li").length + 1;

Expand All @@ -432,7 +432,7 @@ <h2>View Source:</h2>
+ '<div id="' + gridElementName + num_tabs + '" style="width:600px;height:300px;" class="my-grid"></div>'
+ "</div>"
);

CreateGrid(num_tabs);
$("div#tabs").tabs("refresh");
});
Expand Down
20 changes: 10 additions & 10 deletions examples/example-dynamic-with-jquery-tabs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<link rel="shortcut icon" type="image/ico" href="favicon.ico" />
<title>SlickGrid example: jQuery tabs with a dynamic grid in each pane</title>
<link rel="stylesheet" href="../slick.grid.css" type="text/css"/>
<link rel="stylesheet" href="../css/smoothness/jquery-ui.css" type="text/css"/>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/themes/smoothness/jquery-ui.min.css" />
<link rel="stylesheet" href="examples.css" type="text/css"/>
<style>
.my-grid {
Expand Down Expand Up @@ -43,8 +43,8 @@ <h2>View Source:</h2>
</tr>
</table>

<script src="../lib/jquery-3.1.0.js"></script>
<script src="../lib/jquery-ui.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.0/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/jquery-ui.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/sortablejs/Sortable.min.js"></script>

<script src="../slick.core.js"></script>
Expand All @@ -53,7 +53,7 @@ <h2>View Source:</h2>

<script>
var gridArray;

function CreateColumns() {
var columns = [
{id: "title", name: "Title", field: "title"},
Expand Down Expand Up @@ -94,20 +94,20 @@ <h2>View Source:</h2>
}
return data;
}

function CreateGrid(elementId) {
if (!gridArray) { gridArray = []; }

var data = CreateData();
var grid = new Slick.Grid("#" + elementId, data, CreateColumns(), CreateOptions());

gridArray[length] = grid;
}

$(function () {
// take care of jqueryui tabs and adding tab
$( "div#tabs" ).tabs();
$( "div#tabs" ).tabs();

$("button#add-tab").click(function() {
var num_tabs = $("div#tabs ul li").length + 1;

Expand Down
2 changes: 1 addition & 1 deletion examples/example-frozen-columns-and-rows.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<title>SlickGrid example: Frozen Columns and Rows</title>
<link rel="stylesheet" href="../slick.grid.css" type="text/css" media="screen" charset="utf-8"/>
<link rel="stylesheet" href="../controls/slick.pager.css" type="text/css" media="screen" charset="utf-8"/>
<link rel="stylesheet" href="../css/smoothness/jquery-ui.css" type="text/css"/>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/themes/smoothness/jquery-ui.min.css" />
<link rel="stylesheet" href="examples.css" type="text/css" media="screen" charset="utf-8"/>
<link rel="stylesheet" href="../controls/slick.columnpicker.css" type="text/css" media="screen" charset="utf-8"/>
<style>
Expand Down
6 changes: 3 additions & 3 deletions examples/example-frozen-columns-tabs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<title>SlickGrid example: Frozen Columns</title>
<link rel="stylesheet" href="../slick.grid.css" type="text/css" media="screen" charset="utf-8"/>
<link rel="stylesheet" href="../controls/slick.pager.css" type="text/css" media="screen" charset="utf-8"/>
<link rel="stylesheet" href="../css/smoothness/jquery-ui.css" type="text/css"/>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/themes/smoothness/jquery-ui.min.css" />
<link rel="stylesheet" href="examples.css" type="text/css" media="screen" charset="utf-8"/>
<link rel="stylesheet" href="../controls/slick.columnpicker.css" type="text/css" media="screen" charset="utf-8"/>
<style>
Expand Down Expand Up @@ -108,8 +108,8 @@ <h2>Demonstrates:</h2>

<script language="JavaScript" src="../lib/firebugx.js"></script>

<script src="../lib/jquery-3.1.0.js"></script>
<script src="../lib/jquery-ui.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.0/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/jquery-ui.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/sortablejs/Sortable.min.js"></script>

<script src="../slick.core.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion examples/example-frozen-row-reordering.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
</div>

<script src="https://cdn.jsdelivr.net/npm/sortablejs/Sortable.min.js"></script>
<script src="../lib/jquery-3.1.0.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.0/jquery.min.js"></script>
<script src="../lib/jquery.event.drag-2.3.0.js"></script>
<script src="../lib/jquery.event.drop-2.3.0.js"></script>

Expand Down
10 changes: 5 additions & 5 deletions examples/example-jquery-accordion.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<link rel="shortcut icon" type="image/ico" href="favicon.ico" />
<title>SlickGrid example: jQuery Accordion with a grid in each pane</title>
<link rel="stylesheet" href="../slick.grid.css" type="text/css"/>
<link rel="stylesheet" href="../css/smoothness/jquery-ui.css" type="text/css"/>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/themes/smoothness/jquery-ui.min.css" />
<link rel="stylesheet" href="examples.css" type="text/css"/>
<style>
#myGrid01, #myGrid02 {
Expand Down Expand Up @@ -43,8 +43,8 @@ <h2>View Source:</h2>
</tr>
</table>

<script src="../lib/jquery-3.1.0.js"></script>
<script src="../lib/jquery-ui.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.0/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/jquery-ui.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/sortablejs/Sortable.min.js"></script>

<script src="../slick.core.js"></script>
Expand Down Expand Up @@ -87,7 +87,7 @@ <h2>View Source:</h2>
}
return data;
}

$(function () {
$( "#accordion" ).accordion(
// Workaround for IE 7-9 issue where div is blank after switching panels - need to destroy and recreate grid
Expand All @@ -101,7 +101,7 @@ <h2>View Source:</h2>
// }
// }
//}
);
);

var data01 = CreateData();
grid01 = new Slick.Grid("#myGrid01", data01, columns, options);
Expand Down
Loading