Align on latest eclair-core #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
araspitzu
commented
Oct 1, 2019
| @@ -109,11 +109,13 @@ protected void bindItem(final LocalChannel item, final String fiatCode, final Co | |||
| state.setTextColor(ContextCompat.getColor(itemView.getContext(), R.color.orange)); | |||
| } | |||
|
|
|||
|
|
|||
| Long currentBlockHeight = 123L; //appKit.eclairKit.nodeParams().currentBlockHeight(); | |||
There was a problem hiding this comment.
This is the only places left to migrate for the Globals
|
Superceded by #218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the new
MilliSatoshitype introduced in eclair-core with ACINQ/eclair#1088 and removes all the references toGlobalssince it was removed by ACINQ/eclair#1127. Note that this PR is also bumping the dependency to eclair-core0.3.4-android-SNAPSHOTwhich is not yet published.