Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockchain Watchdog : duplicate actor name #1665

Closed
pm47 opened this issue Jan 6, 2021 · 1 comment · Fixed by #1667
Closed

Blockchain Watchdog : duplicate actor name #1665

pm47 opened this issue Jan 6, 2021 · 1 comment · Fixed by #1667
Labels
bug

Comments

@pm47
Copy link
Member

pm47 commented Jan 6, 2021

There seem to be an issue related to supervision:

2020-12-22 22:15:30,457 ERROR akka.actor.ActorCell - Supervisor ResumeSupervisor saw failure: actor name [mempool.space] is not unique!akka.actor.InvalidActorNameException: actor name [mempool.space] is not unique!
2020-12-23 04:47:24,627 ERROR akka.actor.ActorCell - Supervisor ResumeSupervisor saw failure: actor name [blockcypher] is not unique!akka.actor.InvalidActorNameException: actor name [blockcypher] is not unique!
@pm47 pm47 added the bug label Jan 6, 2021
@t-bast
Copy link
Member

t-bast commented Jan 6, 2021

Interesting, that can probably happen when multiple blocks are found in a small time window, and the previous actors haven't been fully stopped yet. We can use unique name by appending a random UUID.

t-bast added a commit that referenced this issue Jan 7, 2021
@t-bast
Blockchain watchdogs use unique actor name
261d3a3 
Actor names cannot conflict.

Even though blockchain watchdog actors stop themselves after fetching block
data, when blocks are found in a short interval, we may end up with multiple
actors of the same type simultaneously alive, so we need them to have
unique names.

The blockcount isn't sufficient to make their names unique because forks
can happen.

Fixes #1665
@t-bast t-bast mentioned this issue Jan 7, 2021
Merged
t-bast added a commit that referenced this issue Jan 19, 2021
@t-bast
Blockchain watchdogs use unique actor name (#1667)
d40b321 
Actor names cannot conflict.

Even though blockchain watchdog actors stop themselves after fetching block
data, when blocks are found in a short interval, we may end up with multiple
actors of the same type simultaneously alive, so we need them to have
unique names.

The blockcount isn't sufficient to make their names unique because forks
can happen.

Fixes #1665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Blockchain watchdogs use unique actor name ACINQ/eclair
2 participants
@pm47 @t-bast