Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Queries: use TLV format for optional data #1072

Merged
merged 16 commits into from
Aug 22, 2019

Commits on Jul 12, 2019

  1. Extended Queries: use TLV format for optional data

    Optional query extensions now use TLV instead of a custom format.
    Flags are encoded as varint instead of bytes as originally proposed. With the current proposal they will all fit on a single byte, but will be
    much easier to extends this way.
    sstone committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    1342621 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Configuration menu
    Copy the full SHA
    bdd0322 View commit details
    Browse the repository at this point in the history
  2. Move query message TLVs to their own namespace

    We add one new class for each TLV type, with specific TLV types, and encapsulate codecs.
    sstone committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    3581e36 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. Optional TLVs are represented as a list, not an optional list

    TLVs that extend regular LN messages can be represented as a TlvStream and not an Option[TlvStream] since we don't need
    to explicitely terminate the stream (either by preprending its length or using a specific terminator) as we do in Onion TLVs.
    
    No TLVs simply means that the TLV stream is empty.
    sstone committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    1b0160c View commit details
    Browse the repository at this point in the history
  2. Update to match BOLT PR

    Checksums in ReplyChannelRange now have the same encoding as short channel ids and timestamps: one byte for
    the encoding type (uncompressed or zlib) followed by encoded data.
    sstone committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    6deaaa3 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. Configuration menu
    Copy the full SHA
    ecd8a2b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    787fd01 View commit details
    Browse the repository at this point in the history
  3. TLV Stream: Implement a generic "get" method for TLV fields

    If a have a TLV stream of type MyTLV which is a subtype of TLV, and MyTLV1 and MYTLV2 are both
    subtypes of MyTLV then we can use stream.get[MyTLV1] to get the TLV record of type MYTLV1 (if any)
    in our TLV stream.
    sstone committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    8dfdf09 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Extended range queries: Implement latest BOLT changes

    Checksums are just transmitted as a raw array, with optional compression as it would be useless here.
    sstone committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    247355b View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Configuration menu
    Copy the full SHA
    f3f213f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. Use extended range queries on regtest and testnet

    We will use them on mainnet as soon as lightning/bolts#557 has been merged.
    sstone committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    d644e4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddcf007 View commit details
    Browse the repository at this point in the history
  3. Address review comments

    sstone committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    b0c2dbc View commit details
    Browse the repository at this point in the history
  4. Router: rework handling of ReplyChannelRange

    We remove the ugly and inefficient zipWithIndex we had before
    sstone committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    c212d9b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b485308 View commit details
    Browse the repository at this point in the history
  6. Router: minor cleanup

    sstone committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    94362f1 View commit details
    Browse the repository at this point in the history