Make tests run in parallel

eclair-core/src/test/resources/application.conf

@@ -12,6 +12,6 @@ akka {
   test {
     # factor by which to scale timeouts during tests, e.g. to account for shared
     # build system load
-    timefactor = 3.0
+    timefactor = 5.0
   }
 }

eclair-core/src/test/scala/fr/acinq/eclair/CltvExpirySpec.scala

@@ -16,13 +16,13 @@
 
 package fr.acinq.eclair
 
-import org.scalatest.FunSuite
+import org.scalatest.{FunSuite, ParallelTestExecution}
 
 /**
  * Created by t-bast on 21/08/2019.
  */
 
-class CltvExpirySpec extends FunSuite {
+class CltvExpirySpec extends FunSuite with ParallelTestExecution {
 
   test("cltv expiry delta") {
     val d = CltvExpiryDelta(561)

eclair-core/src/test/scala/fr/acinq/eclair/CoinUtilsSpec.scala

@@ -17,9 +17,9 @@
 package fr.acinq.eclair
 
 import fr.acinq.bitcoin.{Btc, MilliBtc, Satoshi}
-import org.scalatest.FunSuite
+import org.scalatest.{FunSuite, ParallelTestExecution}
 
-class CoinUtilsSpec  extends FunSuite {
+class CoinUtilsSpec  extends FunSuite with ParallelTestExecution {
 
   test("Convert string amount to the correct BtcAmount") {
     val am_btc: MilliSatoshi = CoinUtils.convertStringAmountToMsat("1", BtcUnit.code)

eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala

@@ -32,14 +32,14 @@ import fr.acinq.eclair.payment.PaymentRequest.ExtraHop
 import fr.acinq.eclair.payment.{LocalPaymentHandler, PaymentRequest}
 import fr.acinq.eclair.router.RouteCalculationSpec.makeUpdate
 import org.mockito.scalatest.IdiomaticMockito
-import org.scalatest.{Outcome, fixture}
+import org.scalatest.{Outcome, ParallelTestExecution, fixture}
 import scodec.bits._
 
 import scala.concurrent.Await
 import scala.concurrent.duration._
 import scala.util.Success
 
-class EclairImplSpec extends TestKit(ActorSystem("mySystem")) with fixture.FunSuiteLike with IdiomaticMockito {
+class EclairImplSpec extends TestKit(ActorSystem("test")) with fixture.FunSuiteLike with IdiomaticMockito with ParallelTestExecution {
 
   implicit val timeout: Timeout = Timeout(30 seconds)
 

eclair-core/src/test/scala/fr/acinq/eclair/TestUtils.scala

@@ -29,7 +29,6 @@ object TestUtils {
     .get("buildDirectory") // this is defined if we run from maven
     .getOrElse(new File(sys.props("user.dir"), "target").getAbsolutePath) // otherwise we probably are in intellij, so we build it manually assuming that user.dir == path to the module
 
-
   def availablePort: Int = synchronized {
     var serverSocket: ServerSocket = null
     try {

eclair-core/src/test/scala/fr/acinq/eclair/blockchain/fee/BitgoFeeProviderSpec.scala

@@ -71,7 +71,7 @@ class BitgoFeeProviderSpec extends FunSuite {
 
   test("make sure API hasn't changed") {
     import scala.concurrent.duration._
-    implicit val system = ActorSystem()
+    implicit val system = ActorSystem("test")
     implicit val ec = system.dispatcher
     implicit val sttp = OkHttpFutureBackend()
     implicit val timeout = Timeout(30 seconds)

eclair-core/src/test/scala/fr/acinq/eclair/channel/ThroughputSpec.scala

@@ -37,7 +37,7 @@ import scala.util.Random
 
 class ThroughputSpec extends FunSuite {
   ignore("throughput") {
-    implicit val system = ActorSystem()
+    implicit val system = ActorSystem("test")
     val pipe = system.actorOf(Props[Pipe], "pipe")
     val blockCount = new AtomicLong()
     val blockchain = system.actorOf(ZmqWatcher.props(blockCount, new TestBitcoinClient()), "blockchain")

eclair-core/src/test/scala/fr/acinq/eclair/channel/states/StateTestsHelperMethods.scala

@@ -31,11 +31,12 @@ import fr.acinq.eclair.router.Hop
 import fr.acinq.eclair.wire.Onion.FinalLegacyPayload
 import fr.acinq.eclair.wire._
 import fr.acinq.eclair.{NodeParams, TestConstants, randomBytes32, _}
+import org.scalatest.{ParallelTestExecution, fixture}
 
 /**
  * Created by PM on 23/08/2016.
  */
-trait StateTestsHelperMethods extends TestKitBase {
+trait StateTestsHelperMethods extends TestKitBase with fixture.TestSuite with ParallelTestExecution {
 
   case class SetupFixture(alice: TestFSMRef[State, Data, Channel],
                           bob: TestFSMRef[State, Data, Channel],
@@ -173,6 +174,7 @@ trait StateTestsHelperMethods extends TestKitBase {
 
   def channelId(a: TestFSMRef[State, Data, Channel]) = Helpers.getChannelId(a.stateData)
 
+
   implicit class ChannelWithTestFeeConf(a: TestFSMRef[State, Data, Channel]) {
     def feeEstimator: TestFeeEstimator = a.underlyingActor.nodeParams.onChainFeeConf.feeEstimator.asInstanceOf[TestFeeEstimator]
 

eclair-core/src/test/scala/fr/acinq/eclair/crypto/NoiseDemo.scala

@@ -25,7 +25,7 @@ import scodec.bits.{ByteVector, _}
   * Created by fabrice on 12/12/16.
   */
 object NoiseDemo extends App {
-  implicit val system = ActorSystem("mySystem")
+  implicit val system = ActorSystem("test")
 
   class NoiseHandler(keyPair: KeyPair, rs: Option[ByteVector], them: ActorRef, isWriter: Boolean, listenerFactory: => ActorRef) extends Actor with Stash {
     // initiator must know pubkey (i.e long-term ID) of responder

eclair-core/src/test/scala/fr/acinq/eclair/router/AnnouncementsBatchValidationSpec.scala

@@ -45,7 +45,7 @@ class AnnouncementsBatchValidationSpec extends FunSuite {
   ignore("validate a batch of announcements") {
     import scala.concurrent.ExecutionContext.Implicits.global
 
-    implicit val system = ActorSystem()
+    implicit val system = ActorSystem("test")
     implicit val sttpBackend = OkHttpFutureBackend()
     implicit val extendedBitcoinClient = new ExtendedBitcoinClient(new BasicBitcoinJsonRPCClient(user = "foo", password = "bar", host = "localhost", port = 18332))
 

eclair-core/src/test/scala/fr/acinq/eclair/router/RouteCalculationSpec.scala

@@ -25,7 +25,7 @@ import fr.acinq.eclair.router.Graph.{RichWeight, WeightRatios}
 import fr.acinq.eclair.transactions.Transactions
 import fr.acinq.eclair.wire._
 import fr.acinq.eclair.{CltvExpiryDelta, LongToBtcAmount, MilliSatoshi, ShortChannelId, ToMilliSatoshiConversion, randomKey}
-import org.scalatest.FunSuite
+import org.scalatest.{FunSuite, ParallelTestExecution}
 import scodec.bits._
 
 import scala.collection.immutable.SortedMap
@@ -35,7 +35,7 @@ import scala.util.{Failure, Success}
  * Created by PM on 31/05/2016.
  */
 
-class RouteCalculationSpec extends FunSuite {
+class RouteCalculationSpec extends FunSuite with ParallelTestExecution {
 
   import RouteCalculationSpec._
 

eclair-core/src/test/scala/fr/acinq/eclair/router/RoutingSyncSpec.scala

@@ -29,7 +29,7 @@ import fr.acinq.eclair.router.Announcements.{makeChannelUpdate, makeNodeAnnounce
 import fr.acinq.eclair.router.BaseRouterSpec.channelAnnouncement
 import fr.acinq.eclair.transactions.Scripts
 import fr.acinq.eclair.wire._
-import org.scalatest.FunSuiteLike
+import org.scalatest.{FunSuiteLike, ParallelTestExecution}
 import scodec.bits.HexStringSyntax
 
 import scala.collection.immutable.TreeMap
@@ -38,7 +38,7 @@ import scala.compat.Platform
 import scala.concurrent.duration._
 
 
-class RoutingSyncSpec extends TestKit(ActorSystem("test")) with FunSuiteLike {
+class RoutingSyncSpec extends TestKit(ActorSystem("test")) with FunSuiteLike with ParallelTestExecution {
 
   import RoutingSyncSpec._
 

eclair-core/src/test/scala/fr/acinq/eclair/wire/ChannelCodecsSpec.scala

@@ -173,7 +173,7 @@ class ChannelCodecsSpec extends FunSuite {
 
   test("encode/decode origin") {
     val id = UUID.randomUUID()
-    assert(originCodec.decodeValue(originCodec.encode(Local(id, Some(ActorSystem("system").deadLetters))).require).require === Local(id, None))
+    assert(originCodec.decodeValue(originCodec.encode(Local(id, Some(ActorSystem("test").deadLetters))).require).require === Local(id, None))
     // TODO: add backward compatibility check
     val relayed = Relayed(randomBytes32, 4324, 12000000 msat, 11000000 msat)
     assert(originCodec.decodeValue(originCodec.encode(relayed).require).require === relayed)

pom.xml

@@ -218,7 +218,7 @@
                 <artifactId>scalatest-maven-plugin</artifactId>
                 <version>2.0.0</version>
                 <configuration>
-                    <parallel>false</parallel>
+                    <parallel>true</parallel>
                     <systemProperties>
                         <buildDirectory>${project.build.directory}</buildDirectory>
                     </systemProperties>