Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix availableForSend/Receive #1293

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Fix availableForSend/Receive #1293

merged 2 commits into from
Jan 28, 2020

Commits on Jan 27, 2020

  1. Fix availableForSend/Receive 

    There was a rounding issue with the availableForSend/Receive calculation.
Because CommitTx fee and Htlc fee were computed separately,
but each was individually rounded down to Satoshis, we could
end up with an off-by-one error.

This resulted in an incapacity to send/receive the maximum amount available.

We now allow computing fees in msat, which removes rounding issues.
    @t-bast
    t-bast committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    5831f12 View commit details
    Browse the repository at this point in the history

  2. Fix fuzz test 

    Otherwise we may run into the following issue:
lightning/bolts#728
    @t-bast
    t-bast committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    1628192 View commit details
    Browse the repository at this point in the history