Funder reserve for future fee increase #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
remote-cannot-afford-increased-fee
branch
from
5acd6f5
to
efee031
Compare
See lightning/bolts#728 Add an additional reserve on the funder to prevent emptying and then being stuck with an unusable channel. As fundee we don't verify funders comply with that change. We may enforce it in the future when we're confident the network as a whole enforces that.
t-bast
force-pushed
the
remote-cannot-afford-increased-fee
branch
from
efee031
to
7d7dffb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
=========================================
+ Coverage 77.72% 77.8% +0.07%
=========================================
Files 144 144
Lines 10164 10167 +3
Branches 404 414 +10
=========================================
+ Hits 7900 7910 +10
+ Misses 2264 2257 -7
|
pm47
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See lightning/bolts#728 and lightning/bolts#740.
Add an additional reserve on the funder to prevent emptying and then being stuck with an unusable channel.
As fundee we don't verify funders comply with that change.
We may enforce it in the future when we're confident the network as a whole enforces that.
Note that c-lightning has already implemented the same logic. We can merge this regardless of spec inclusion as a safety measure for our nodes (and I think we should). The spec may bikeshed some details (like the factor) which we can update later.
@pm47 this is now ready for review.