Improve CustomCommitmentsPlugin methods #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akumaigorodski
commented
Nov 22, 2020
akumaigorodski
commented
Nov 22, 2020
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/PostRestartHtlcCleaner.scala
Outdated
Show resolved
Hide resolved
akumaigorodski
commented
Nov 22, 2020
| @@ -329,9 +331,25 @@ object PostRestartHtlcCleaner { | |||
| private def isPendingUpstream(channelId: ByteVector32, htlcId: Long, htlcsIn: Seq[IncomingHtlc]): Boolean = | |||
| htlcsIn.exists(htlc => htlc.add.channelId == channelId && htlc.add.id == htlcId) | |||
|
|
|||
| def groupByOrigin(htlcsOut: Seq[(Origin, ByteVector32, Long)], htlcsIn: Seq[IncomingHtlc]): Map[Origin, Set[ChannelIdAndHtlcId]] = | |||
There was a problem hiding this comment.
This piece of code is non-trivial and reused in plugin so I've made it a separate method similar to PostRestartHtlcCleaner.decryptedIncomingHtlcs.
akumaigorodski
commented
Nov 22, 2020
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/PostRestartHtlcCleaner.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1613 +/- ##
==========================================
+ Coverage 87.29% 87.36% +0.06%
==========================================
Files 146 146
Lines 11061 11063 +2
Branches 466 474 +8
==========================================
+ Hits 9656 9665 +9
+ Misses 1405 1398 -7
|
t-bast
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of small changes to make
CustomCommitmentsPluginmethods easier to works with.