Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup! Distribute connection-handling on multiple machines (#1566) #1634

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Dec 14, 2020

This fixes the Docker build which was failing due to the new child module eclair-front.

We should probably add a way to start an eclair-front from docker too.

@pm47 pm47 requested a review from t-bast December 14, 2020 16:10
@t-bast
Copy link
Member

t-bast commented Dec 14, 2020

We should probably add a way to start an eclair-front from docker too.

I don't know, since we don't recommend running it via docker for any kind of meaningful deployment, I'm not sure it's useful, is it?

@codecov-io
Copy link

Codecov Report

Merging #1634 (c30f30b) into master (0e5ec4d) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
+ Coverage   85.88%   85.93%   +0.05%     
==========================================
  Files         151      151              
  Lines       11417    11417              
  Branches      492      492              
==========================================
+ Hits         9805     9811       +6     
+ Misses       1612     1606       -6     
Impacted Files Coverage Δ
...main/scala/fr/acinq/eclair/router/Validation.scala 91.41% <0.00%> (-1.50%) ⬇️
...nq/eclair/blockchain/electrum/ElectrumWallet.scala 80.25% <0.00%> (-0.26%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.04% <0.00%> (ø)
...nq/eclair/blockchain/electrum/ElectrumClient.scala 73.89% <0.00%> (+0.36%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 95.27% <0.00%> (+1.57%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 77.77% <0.00%> (+3.17%) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 78.49% <0.00%> (+4.30%) ⬆️

@pm47
Copy link
Member Author

pm47 commented Dec 14, 2020

We should probably add a way to start an eclair-front from docker too.

I don't know, since we don't recommend running it via docker for any kind of meaningful deployment, I'm not sure it's useful, is it?

True!

@pm47 pm47 merged commit 0ce993d into master Dec 14, 2020
@pm47 pm47 deleted the fix-docker-eclair-front branch December 14, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants