-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate static_remotekey by default #1639
Conversation
We activate static_remotekey by default (optional). This is necessary since lnd will start making it mandatory in their next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
features = Features(Set( | ||
ActivatedFeature(InitialRoutingSync, Optional), | ||
ActivatedFeature(OptionDataLossProtect, Optional), | ||
ActivatedFeature(ChannelRangeQueries, Optional), | ||
ActivatedFeature(ChannelRangeQueriesExtended, Optional), | ||
ActivatedFeature(VariableLengthOnion, Optional), | ||
ActivatedFeature(PaymentSecret, Optional), | ||
ActivatedFeature(BasicMultiPartPayment, Optional) | ||
)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 reformatting
lazy val handlerWithoutMpp = TestActorRef[PaymentHandler](PaymentHandler.props(nodeParams.copy(features = featuresWithoutMpp), register.ref)) | ||
lazy val handlerWithMpp = TestActorRef[PaymentHandler](PaymentHandler.props(nodeParams.copy(features = featuresWithMpp), register.ref)) | ||
lazy val handlerWithKeySend = TestActorRef[PaymentHandler](PaymentHandler.props(nodeParams.copy(features = featuresWithKeySend), register.ref)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 renaming
We activate static_remotekey by default (optional).
This is necessary since lnd will start making it mandatory in their next release.