Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rare race conditions in integration tests #1653

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Fix rare race conditions in integration tests #1653

merged 2 commits into from
Jan 6, 2021

Commits on Dec 18, 2020

  1. Fix rare race condition in integration tests 

    When a channel goes to the CLOSED state, the actor will stop itself.

We were previously sending messages to the actor asking for its state,
which returns a failure when the actor is stopped. We can simply listen
to state events to safely get the same result.
    @t-bast
    t-bast committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    676e6c2 View commit details
    Browse the repository at this point in the history

  2. More robust disconnection

    @t-bast
    t-bast committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    0f91f20 View commit details
    Browse the repository at this point in the history