Refactor channel test helpers #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful to separate these test methods in a dedicated trait instead of always bundling it with `FixtureTestSuite`. In particular, it was previously impossible to use both `BitcoindService` and `StateTestsHelperMethods` because `BitcoindService` doesn't work with fixtures (it leverages `beforeAll` and `afterAll` instead because launching one bitcoind instance per-test would be too expensive and useless).
Codecov Report
@@ Coverage Diff @@
## master #1682 +/- ##
==========================================
+ Coverage 85.87% 85.98% +0.11%
==========================================
Files 151 151
Lines 11439 11439
Branches 505 505
==========================================
+ Hits 9823 9836 +13
+ Misses 1616 1603 -13
|
pm47
reviewed
Feb 4, 2021
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/StateTestsHelperMethods.scala
Show resolved
Hide resolved
pm47
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to separate these test methods in a dedicated trait instead of always bundling it with
FixtureTestSuite.In particular, it was previously impossible to use both
BitcoindServiceandStateTestsHelperMethodsbecauseBitcoindServicedoesn't work with fixtures (it leveragesbeforeAllandafterAllinstead because launching one bitcoind instance per-test would be too expensive and useless).My goal is to then use this new
StateTestsHelperMethodsin theZmqWatcherSpec(and other related actors) to test the CPFP and RBF logic against real commitments.