Reenable ServerSocket tests #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are issues with IPv6 loopback addresses on build machines, so we force IPv4 and use non-blocking socket servers.
t-bast
force-pushed
the
fix-server-socket-tests
branch
from
0d70289
to
d8b4596
Compare
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
==========================================
+ Coverage 89.29% 89.33% +0.03%
==========================================
Files 144 144
Lines 10892 10903 +11
Branches 459 475 +16
==========================================
+ Hits 9726 9740 +14
+ Misses 1166 1163 -3
|
pm47
approved these changes
Apr 20, 2021
| val mockServer = ServerSocketChannel.open() | ||
| // NB: we force 127.0.0.1 (IPv4) because there are issues on ubuntu build machines with IPv6 loopback | ||
| mockServer.bind(new InetSocketAddress("127.0.0.1", 0)) | ||
| mockServer.configureBlocking(false) |
There was a problem hiding this comment.
I discovered that one while I was thinking that the issue was a deadlock on the server. It didn't fix the build, but it's still an improvement 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues with IPv6 loopback addresses on build machines, so we force IPv4 and use non-blocking socket servers.