Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements and fixes #1817

Merged
merged 8 commits into from
May 25, 2021
Merged

Various improvements and fixes #1817

merged 8 commits into from
May 25, 2021

Commits on May 25, 2021

  1. Improve logs 

    * Reduce log level for explorer API errors
* Reduce log level for remote peer invalid open_channel
    @t-bast
    t-bast committed May 25, 2021
    Configuration menu
    Copy the full SHA
    fe3bf4f View commit details
    Browse the repository at this point in the history

  2. Don't send duplicate commands in PostRestart 

    If there is already a pending HTLC settlement command in the DB, the
post-restart handler should let the channel replay it instead of sending
a conflicting command.
    @t-bast
    t-bast committed May 25, 2021
    Configuration menu
    Copy the full SHA
    11370d7 View commit details
    Browse the repository at this point in the history

  3. Workaround for lnd bug in reestablish 

    Sometimes lnd sends announcement_signatures before sending their channel
reestablish. This is a minor spec violation, we can simply delay the message
and handle it later (hopefully once we've received their reestablish).
    @t-bast
    t-bast committed May 25, 2021
    Configuration menu
    Copy the full SHA
    dcf5f83 View commit details
    Browse the repository at this point in the history

  4. Log shared secrets in Sphinx error 

    Breez sometimes returns errors that we fail to parse.
Unfortunately we didn't correctly log the shared secrets because the
variable was shadowed, so we can't investigate further for now.
    @t-bast
    t-bast committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d2dae9d View commit details
    Browse the repository at this point in the history

  5. Fix utxo metric checks 

    If we're unable to fetch the number of unconfirmed parents for a utxo,
this shouldn't cause the global utxo check to fail. We log a warning and
let operations continue to ensure the metric is updated.
    @t-bast
    t-bast committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d508174 View commit details
    Browse the repository at this point in the history

  6. Add logs for unknown sphinx error packets 

    We're seeing some instances of the following error in our logs:

cannot parse returned error: class fr.acinq.eclair.wire.protocol.UnknownMessage
cannot be cast to class fr.acinq.eclair.wire.protocol.ChannelUpdate

Logging the bytes and shared secrets will let us investigate these.
    @t-bast
    t-bast committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7e95e02 View commit details
    Browse the repository at this point in the history

  7. Handle ChannelIdAssigned when disconnected 

    There may be a race condition where a peer disconnect in the middle of a
channel id assignment. In that case, we still want to record the up-to-date
mapping.
    @t-bast
    t-bast committed May 25, 2021
    Configuration menu
    Copy the full SHA
    60655e5 View commit details
    Browse the repository at this point in the history

  8. Fix PR comments

    @t-bast
    t-bast committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ee9a1e0 View commit details
    Browse the repository at this point in the history