Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule backup at regular interval #1845

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Schedule backup at regular interval #1845

merged 4 commits into from
Jun 23, 2021

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Jun 22, 2021

This is a bit less trigger happy than previously, and the implementation
is simpler.

This is a bit less trigger happy than previously, and the implementation
is simpler.
pm47 added 2 commits June 23, 2021 10:28
That way we don't block the actor and prevent messages from piling up in
the mailbox.
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #1845 (83ed672) into master (afb1b41) will decrease coverage by 0.15%.
The diff coverage is 74.35%.

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage   89.09%   88.93%   -0.16%     
==========================================
  Files         146      150       +4     
  Lines       10994    11237     +243     
  Branches      444      429      -15     
==========================================
+ Hits         9795     9994     +199     
- Misses       1199     1243      +44     
Impacted Files Coverage Δ
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala 79.88% <14.28%> (-0.48%) ⬇️
...n/scala/fr/acinq/eclair/db/FileBackupHandler.scala 86.20% <86.20%> (+14.77%) ⬆️
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala 92.85% <100.00%> (+0.11%) ⬆️
...clair/blockchain/bitcoind/rpc/BatchingClient.scala 86.36% <0.00%> (-13.64%) ⬇️
...lockchain/bitcoind/rpc/ExtendedBitcoinClient.scala 93.93% <0.00%> (-2.49%) ⬇️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 96.09% <0.00%> (-0.79%) ⬇️
...eclair/blockchain/bitcoind/BitcoinCoreWallet.scala 89.70% <0.00%> (-0.71%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.19% <0.00%> (ø)
...n/scala/fr/acinq/eclair/channel/ChannelTypes.scala 97.14% <0.00%> (ø)
...la/fr/acinq/eclair/transactions/Transactions.scala 96.78% <0.00%> (ø)
... and 9 more

@pm47 pm47 merged commit 45204e2 into master Jun 23, 2021
@pm47 pm47 deleted the improve-backup branch June 23, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants