Only store remote sigs for the local commit #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
reviewed
Jun 25, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
t-bast
reviewed
Jun 25, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/h/ClosingStateSpec.scala
Show resolved
Hide resolved
t-bast
reviewed
Jun 28, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version0/ChannelCodecs0.scala
Outdated
Show resolved
Hide resolved
t-bast
reviewed
Jun 28, 2021
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version3/ChannelCodecs3.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version3/ChannelCodecs3.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/StateTestsHelperMethods.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/StateTestsHelperMethods.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/h/ClosingStateSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/h/ClosingStateSpec.scala
Outdated
Show resolved
Hide resolved
pm47
force-pushed
the
only-store-remote-sigs
branch
3 times, most recently
from
9242f49
to
2e074f7
Compare
t-bast
force-pushed
the
only-store-remote-sigs
branch
from
a1e31f5
to
2e074f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1849 +/- ##
==========================================
+ Coverage 87.04% 87.27% +0.22%
==========================================
Files 156 159 +3
Lines 11724 11935 +211
Branches 476 466 -10
==========================================
+ Hits 10205 10416 +211
Misses 1519 1519
|
pm47
force-pushed
the
only-store-remote-sigs
branch
from
e88e6c5
to
226b609
Compare
pm47
commented
Jul 8, 2021
pm47
commented
Jul 8, 2021
eclair-core/src/test/scala/fr/acinq/eclair/wire/internal/channel/ChannelCodecsSpec.scala
Show resolved
Hide resolved
pm47
commented
Jul 9, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelTypes.scala
Outdated
Show resolved
Hide resolved
pm47
commented
Jul 9, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala
Show resolved
Hide resolved
t-bast
reviewed
Jul 12, 2021
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/StateTestsHelperMethods.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/StateTestsHelperMethods.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/wire/internal/channel/ChannelCodecsSpec.scala
Outdated
Show resolved
Hide resolved
pm47
force-pushed
the
only-store-remote-sigs
branch
from
dfc5746
to
51b6bd7
Compare
t-bast
previously approved these changes
Jul 12, 2021
There was a problem hiding this comment.
LGTM, there's only this comment that hasn't been addressed: #1849 (comment)
t-bast
previously approved these changes
Jul 12, 2021
pm47
force-pushed
the
only-store-remote-sigs
branch
2 times, most recently
from
6b0d185
to
2c2078e
Compare
t-bast
previously approved these changes
Jul 12, 2021
t-bast
previously approved these changes
Jul 13, 2021
That way, even if the node database or a backup is compromised, the attacker won't be able to force close channels from the outside.
* Separate internal channel config from features Our current ChannelVersion field mixes two unrelated concepts: channel features (as defined in Bolt 9) and channel internals (such as custom key derivation). It is more future-proof to separate these two unrelated concepts and will make it easier to implement channel types (see lightning/bolts#880). * Add shutdown script to channel remote params This will be necessary when we implement `upfront_shutdown_script`. This field can be set to `None` for all current channels as we don't support the feature yet.
pm47
force-pushed
the
only-store-remote-sigs
branch
from
71fb7db
to
cdb7f4a
Compare
t-bast
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way, even if the node database or a backup is compromised, the attacker won't be able to force close channels from the outside.
This is best reviewed commit by commit.