Trampoline payments use per-channel fee and cltv #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomash-acinq
requested review from
t-bast and
pm47
and removed request for
t-bast
thomash-acinq
force-pushed
the
no-more-trampoline-discount
branch
from
16118b6
to
42dd0db
Compare
Codecov Report
@@ Coverage Diff @@
## master #1853 +/- ##
==========================================
+ Coverage 88.94% 88.99% +0.04%
==========================================
Files 150 150
Lines 11239 11241 +2
Branches 447 460 +13
==========================================
+ Hits 9997 10004 +7
+ Misses 1242 1237 -5
|
t-bast
reviewed
Jul 1, 2021
| @@ -120,12 +120,13 @@ object NodeRelay { | |||
|
|
|||
| /** Compute route params that honor our fee and cltv requirements. */ | |||
| def computeRouteParams(nodeParams: NodeParams, amountIn: MilliSatoshi, expiryIn: CltvExpiry, amountOut: MilliSatoshi, expiryOut: CltvExpiry): RouteParams = { | |||
There was a problem hiding this comment.
NB: we still verify in validateRelay above that the fee is at least our current default fee, so we ignore the fact that we may have channels that require lower fees and could relay this payment.
But I think it's the right behavior to have, trampoline is more computationally expensive than standard channel-relay so it makes sense to have a higher threshold than our cheapest channels.
eclair-core/src/test/scala/fr/acinq/eclair/router/RouteCalculationSpec.scala
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure trampoline users pay at least as much as the other users.