Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default file backup config #1857

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Fix default file backup config #1857

merged 1 commit into from
Jul 2, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Jul 2, 2021

The file-backup section should be inside eclair, otherwise startup fails.

The `file-backup` section should be inside `eclair`, otherwise startup fails.
@t-bast t-bast requested a review from pm47 July 2, 2021 08:31
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embarrassing. Here is a micro post mortem:

  • the bug wasn't caught by the integration tests because we explicitly disable db backups for them (using the correct config path)
  • the bug wasn't caught by the StartupSpec test either because the config isn't handled by NodeParams.

@codecov-commenter
Copy link

Codecov Report

Merging #1857 (d2dad2e) into master (f52c3dd) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1857      +/-   ##
==========================================
- Coverage   88.96%   88.93%   -0.03%     
==========================================
  Files         150      150              
  Lines       11250    11250              
  Branches      457      457              
==========================================
- Hits        10008    10005       -3     
- Misses       1242     1245       +3     
Impacted Files Coverage Δ
...clair/blockchain/bitcoind/rpc/BatchingClient.scala 86.36% <0.00%> (-13.64%) ⬇️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 96.09% <0.00%> (-0.79%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.27% <0.00%> (+0.08%) ⬆️

@t-bast t-bast merged commit 516929b into master Jul 2, 2021
@t-bast t-bast deleted the fix-file-backup-config branch July 2, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants