-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bolt 11 official test vectors #1870
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1870 +/- ##
======================================
Coverage 8.96% 8.96%
======================================
Files 158 158
Lines 12330 12335 +5
Branches 530 515 -15
======================================
+ Hits 1105 1106 +1
- Misses 11225 11229 +4
|
0012da3
to
b3feeff
Compare
it seems that the |
Good catch, it was missing because we actually didn't implement that check! |
LGTM, but we probably should wait until lightning/bolts#898 has been merged ? |
Yes sure, let's wait for the spec PR to be accepted before merging here. |
Add payment secrets (see lightning/bolts#887)
Add feature bits, as indicated by lightning/bolts#898
cd65bbe
to
8d42235
Compare
lightning/bolts#898 has just been merged, so we can merge this PR now. |
Add payment secrets (see lightning/bolts#887)
We'll wait for the next release, and then change the
payment_secret
field to be non-optional