Fetch incoming payments in parallel #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simpler approach to completely parallelizing the handling of payments, where we simply parallelize the fetch from the database. This brings a ~30% performance improvement in performance in `PerformanceIntegrationSpec`.
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
==========================================
+ Coverage 87.32% 87.35% +0.03%
==========================================
Files 159 159
Lines 11955 11960 +5
Branches 476 475 -1
==========================================
+ Hits 10440 10448 +8
+ Misses 1515 1512 -3
|
pm47
added a commit
that referenced
this pull request
Jul 16, 2021
The parallelization introduced with #1880 has created race conditions in tests.
pm47
added a commit
that referenced
this pull request
Jul 16, 2021
The parallelization introduced with #1880 has created race conditions in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler approach to completely parallelizing the handling of payments (attempted in branch parallel-payment-handler), where we simply parallelize the fetch from the database.
The advantage is that it is a much smaller change, that already brings a ~30% performance improvement in performance in
PerformanceIntegrationSpec.