Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate local alias before spawning channel #2316

Closed
wants to merge 4 commits into from
Closed

Generate local alias before spawning channel #2316

wants to merge 4 commits into from

Commits on Jun 16, 2022

  1. generate local alias before spawning channel

    @pm47
    pm47 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    5f3fa19 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. use last 7B of channel_id for alias 

    Using the first 7B increases the risk of collision at migration due to
how `channel_id` is built. Collisions would happen when multiple
channels are funded with the same transaction.
    @pm47
    pm47 committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    d900265 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @pm47
    pm47 committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    4ee1025 View commit details
    Browse the repository at this point in the history

  3. random local alias with collision protection

    @pm47
    pm47 committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    60f581c View commit details
    Browse the repository at this point in the history