Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup! Add metrics on splicing (#2756) #2759

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Fixup! Add metrics on splicing (#2756) #2759

merged 2 commits into from
Sep 29, 2023

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Sep 29, 2023

We were considering all local outputs as splice outputs, but some may be change.

@pm47 pm47 requested a review from t-bast September 29, 2023 14:48
@codecov-commenter
Copy link

Codecov Report

Merging #2759 (1ef7e6d) into master (e4103a2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
- Coverage   85.87%   85.87%   -0.01%     
==========================================
  Files         216      216              
  Lines       18089    18090       +1     
  Branches      737      785      +48     
==========================================
  Hits        15534    15534              
- Misses       2555     2556       +1     
Files Coverage Δ
...ain/scala/fr/acinq/eclair/channel/Monitoring.scala 95.91% <100.00%> (ø)
...inq/eclair/channel/fund/InteractiveTxBuilder.scala 91.50% <100.00%> (+0.02%) ⬆️

... and 5 files with indirect coverage changes

@pm47 pm47 merged commit db8e0f9 into master Sep 29, 2023
1 check passed
@pm47 pm47 deleted the fix-splice-metrics branch September 29, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants