Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate dual funding by default #2825

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Activate dual funding by default #2825

merged 2 commits into from
Feb 28, 2024

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Feb 16, 2024

And update the release notes.

And update the release notes.
@t-bast t-bast marked this pull request as ready for review February 27, 2024 16:04
@t-bast t-bast requested a review from remyers February 27, 2024 16:04
Copy link
Contributor

@remyers remyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just a few nits/typos in the release notes.

I couldn't find the explanation of the switch in MinimalNodeFixture from DummyOnChainWallet to SingleKeyOnChainWallet.

I can see that tests fail without that change, but some more information about the switch would make that change easier to review.

docs/release-notes/eclair-vnext.md Outdated Show resolved Hide resolved
docs/release-notes/eclair-vnext.md Outdated Show resolved Hide resolved
docs/release-notes/eclair-vnext.md Outdated Show resolved Hide resolved
- clarify wording around activation
- link to sample plugin
@t-bast
Copy link
Member Author

t-bast commented Feb 28, 2024

I couldn't find the explanation of the switch in MinimalNodeFixture from DummyOnChainWallet to SingleKeyOnChainWallet.

Right, that's because the DummyOnChainWallet is overriding the makeFundingTx function which is used for single-funded channels, but its override of the fundTransaction function that is used for dual-funding is basically a no-op that returns the transaction as-is. This breaks dual funding entirely because it doesn't really return a funded transaction.

The SingleKeyOnChainWallet is a better mock for an on-chain wallet that supports funding transactions, which makes it work for dual funding tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.93%. Comparing base (fd0cdf6) to head (e551ecf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2825      +/-   ##
==========================================
- Coverage   85.99%   85.93%   -0.06%     
==========================================
  Files         219      219              
  Lines       18453    18453              
  Branches      766      766              
==========================================
- Hits        15869    15858      -11     
- Misses       2584     2595      +11     

see 8 files with indirect coverage changes

@t-bast t-bast requested a review from remyers February 28, 2024 14:04
Copy link
Contributor

@remyers remyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to go.

@t-bast t-bast merged commit 8723d35 into master Feb 28, 2024
1 check passed
@t-bast t-bast deleted the activate-dual-funding branch February 28, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants