Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix to ROCm 6.1 #350

Merged
merged 5 commits into from
Aug 7, 2024
Merged

CI: Fix to ROCm 6.1 #350

merged 5 commits into from
Aug 7, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 6, 2024

ROCm 6.1.2->6.2.0 switches Clang 17 to 18.
The current setup led to linker issues on Ubuntu 20.04:

ld.lld: error: undefined hidden symbol: __hip_gpubin_handle_f20551e8c5453d2a
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_ctor.1796)
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_ctor.1796)
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_dtor.1798)
>>> referenced 1 more times

https://rocm.docs.amd.com/projects/HIP/en/docs-5.7.1/user_guide/hip_porting_driver_api.html#hip-clang-implementation-notes
image

switch from clang++ to hipcc as the compiler.

@ax3l ax3l added component: tests tests and examples component: third party Changes in ImpactX that reflect a change in a third-party library labels Aug 6, 2024
@ax3l ax3l requested a review from WeiqunZhang August 6, 2024 21:53
@ax3l
Copy link
Member Author

ax3l commented Aug 6, 2024

huh, still fails with the same error.

@ax3l ax3l force-pushed the fix-rocm-6.2.0 branch 2 times, most recently from ed1dd95 to dc40d8e Compare August 7, 2024 16:47
@ax3l ax3l changed the title CI: Fix ROCm 6.2.0 CI: Fix to ROCm 6.1 Aug 7, 2024
@ax3l
Copy link
Member Author

ax3l commented Aug 7, 2024

Will stick with ROCm 6.1 for now...

ROCm 6.1.2->6.2.0 switches Clang 17 to 18.
The current setup led to linker issues:
```
ld.lld: error: undefined hidden symbol: __hip_gpubin_handle_f20551e8c5453d2a
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_ctor.1796)
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_ctor.1796)
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_dtor.1798)
>>> referenced 1 more times
```

switch from clang++ to hipcc as the compiler.
@ax3l ax3l merged commit 1eefbcb into AMReX-Codes:development Aug 7, 2024
19 of 20 checks passed
@ax3l ax3l deleted the fix-rocm-6.2.0 branch August 7, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests tests and examples component: third party Changes in ImpactX that reflect a change in a third-party library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants