Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Save PR Number Once #360

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 28, 2024

Only run the save_pr_number script once per PR.

@WeiqunZhang, should this run for all our workflows per PR

  • last
  • first
  • at any time in parallel to running tests
  • only on success of all tests
  • ...?

Only run the `save_pr_number` script once per PR.
@ax3l ax3l added bug Something isn't working component: tests tests and examples labels Aug 28, 2024
@ax3l ax3l requested a review from WeiqunZhang August 28, 2024 20:51
@@ -120,18 +120,3 @@ jobs:
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: sarif-results/${{ matrix.language }}.sarif

save_pr_number:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also in ci.yml, which calls this workflow script after other prerequisite runs have succeeded.

@ax3l ax3l merged commit 4f197ca into AMReX-Codes:development Aug 29, 2024
19 checks passed
@ax3l ax3l deleted the fix-one-save-pr-number branch August 29, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: tests tests and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants