Merge pull request godotengine#96127 from RedOrbweaver/fix_msbuild_lo…

…gger_crash [3.x] Fix MSBuild logger exception thrown when processing a warning or an error with no associated file
AThousandShips · Sep 12, 2024 · db51187 · db51187
2 parents d6d2951 + 5cbe7fd
commit db51187
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/mono/editor/GodotTools/GodotTools.BuildLogger/GodotBuildLogger.cs b/modules/mono/editor/GodotTools/GodotTools.BuildLogger/GodotBuildLogger.cs
@@ -88,7 +88,7 @@ private void eventSource_ErrorRaised(object sender, BuildErrorEventArgs e)
 
             WriteLine(line);
 
-            string errorLine = $@"error,{e.File.CsvEscape()},{e.LineNumber},{e.ColumnNumber}," +
+            string errorLine = $@"error,{e.File?.CsvEscape() ?? string.Empty},{e.LineNumber},{e.ColumnNumber}," +
                                $"{e.Code?.CsvEscape() ?? string.Empty},{e.Message.CsvEscape()}," +
                                $"{e.ProjectFile?.CsvEscape() ?? string.Empty}";
             _issuesStreamWriter.WriteLine(errorLine);
@@ -103,7 +103,7 @@ private void eventSource_WarningRaised(object sender, BuildWarningEventArgs e)
 
             WriteLine(line);
 
-            string warningLine = $@"warning,{e.File.CsvEscape()},{e.LineNumber},{e.ColumnNumber}," +
+            string warningLine = $@"warning,{e.File?.CsvEscape() ?? string.Empty},{e.LineNumber},{e.ColumnNumber}," +
                                  $"{e.Code?.CsvEscape() ?? string.Empty},{e.Message.CsvEscape()}," +
                                  $"{e.ProjectFile?.CsvEscape() ?? string.Empty}";
             _issuesStreamWriter.WriteLine(warningLine);