Merge pull request #147 from staticdev/bugfix/linting-issues

Fix linting issues

.ansible-lint.yml

@@ -2,7 +2,6 @@
 exclude_paths:
   - .ansible
   - .venv
-  - molecule/*/converge.yml
 parseable: true
 skip_list:
   - "empty-string-compare"

molecule/default/converge.yml

@@ -13,7 +13,7 @@
     - name: Get list of installed Nix packages
       become: true
       become_user: "{{ nix_user }}"
-      shell: "nix-env --query --installed"
+      ansible.builtin.command: "nix-env --query --installed"
       environment:
         PATH: "/home/{{ nix_user }}/.nix-profile/bin:{{ lookup('env', 'PATH') }}"
       changed_when: false
@@ -22,29 +22,30 @@
     - name: Try to install a Nix package
       become: true
       become_user: "{{ nix_user }}"
-      shell: "nix-env -i hello"
+      ansible.builtin.command: "nix-env -i hello"
       environment:
         PATH: "/home/{{ nix_user }}/.nix-profile/bin:{{ lookup('env', 'PATH') }}"
       when: "'hello' not in nix_packages.stdout"
+      changed_when: true
 
     - name: Try to run the hello Nix package
       become: true
       become_user: "{{ nix_user }}"
-      command: "hello"
+      ansible.builtin.command: "hello"
       environment:
         PATH: "/home/{{ nix_user }}/.nix-profile/bin:{{ lookup('env', 'PATH') }}"
       changed_when: false
       register: hello_output
 
     - name: Verify output of the hello program
-      fail:
+      ansible.builtin.fail:
         msg: "The hello program did not return the expected output!"
       when: "hello_output.stdout != 'Hello, world!'"
 
     - name: Try to use Nix Flakes
       become: true
       become_user: "{{ nix_user }}"
-      shell: "nix flake metadata github:edolstra/dwarffs"
+      ansible.builtin.command: "nix flake metadata github:edolstra/dwarffs"
       environment:
         PATH: "/home/{{ nix_user }}/.nix-profile/bin:{{ lookup('env', 'PATH') }}"
       changed_when: false

requirements-dev.in

@@ -2,3 +2,5 @@ ansible-core
 ansible-lint
 molecule
 molecule-plugins[docker]
+# https://github.com/docker/docker-py/issues/3113
+urllib3<2

requirements-dev.txt

@@ -154,8 +154,9 @@ text-unidecode==1.3
     # via python-slugify
 tomli==2.0.1
     # via black
-urllib3==2.0.3
+urllib3==1.26.16
     # via
+    #   -r requirements-dev.in
     #   docker
     #   requests
 wcmatch==8.4.1