Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud manager report partial fix #3294

Conversation

MikhailNavitski
Copy link
Contributor

Partial fix for the following bugs/code smells from the CM report:
2931

  1. squid:S2259
  2. AEM Rules:AEM-1
  3. CQRules:CQBP-44---CatchAndEitherLogOrThrow

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 55.45%. Comparing base (b0a4f23) to head (b0b3fbf).
Report is 7 commits behind head on master.

❗ Current head b0b3fbf differs from pull request most recent head 5ebef0e. Consider uploading reports for the commit 5ebef0e to get more accurate results

Files Patch % Lines
...ommons/audit_log_search/AuditLogSearchRequest.java 25.00% 1 Missing and 2 partials ⚠️
...sign/dynamicdeckdynamo/utils/DynamicDeckUtils.java 0.00% 3 Missing ⚠️
...ss/impl/SyncSmartTagsToXmpMetadataNodeProcess.java 25.00% 1 Missing and 2 partials ⚠️
.../commons/dam/impl/ReviewTaskAssetMoverHandler.java 0.00% 0 Missing and 1 partial ⚠️
...ow/processes/impl/DynamicDeckBackTrackProcess.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3294   +/-   ##
=========================================
  Coverage     55.45%   55.45%           
- Complexity     5506     5507    +1     
=========================================
  Files           721      721           
  Lines         29534    29535    +1     
  Branches       3840     3841    +1     
=========================================
+ Hits          16378    16379    +1     
+ Misses        11630    11628    -2     
- Partials       1526     1528    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikhailNavitski MikhailNavitski force-pushed the bugfix/2931/cloud-manager-report-partial-fix branch from 6b7cd28 to b0b3fbf Compare March 19, 2024 16:04
@davidjgonzalez davidjgonzalez merged commit 3689bb4 into Adobe-Consulting-Services:master Mar 22, 2024
9 of 10 checks passed
YegorKozlov pushed a commit to YegorKozlov/acs-aem-commons that referenced this pull request Mar 25, 2024
Co-authored-by: david g <davidjgonzalez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants