Amend header to match checkstyle format #3382
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkstyle code status on this project has 1,634 issues, mostly because of one rule violation. Checkstyle compares the Java header to
.codeclimate/header.txt
but because " Bundle" is omitted, none of these match. I've updated the header on all java files for the main bundle but have not touched a few references in oakpal-checks. Please let me know if you want to add a qualifier to any of these and I can amend e.g. "ACS AEM Commons Oakpal Checks Bundle".The pattern:
Build status showing the issue mixed with other minor Checkstyle issues:
https://codeclimate.com/github/Adobe-Consulting-Services/acs-aem-commons/issues?status%5B%5D=&engine_name%5B%5D=checkstyle
The proper header template file has also been applied across the whole bundle to standardise optional lines, add copyright start dates, remove rogue characters and to fix spacing between the header and the package line.