Move SyslogAppender into separate onprem bundle #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
reviewed
Aug 7, 2024
kwin
reviewed
Aug 7, 2024
| <plugins> | ||
| <plugin> | ||
| <groupId>biz.aQute.bnd</groupId> | ||
| <artifactId>bnd-maven-plugin</artifactId> |
There was a problem hiding this comment.
I am wondering whether we should make this a fragment of com.adobe.acs.acs-aem-commons-bundle similar to the Cloud bundle in order to consume non-exported classes from it.
There was a problem hiding this comment.
I thought about this, too - not sure how likely that use case actually is and therefore decided to go with a plain old bundle.
There was a problem hiding this comment.
ok, we can do it later on if needed.
There was a problem hiding this comment.
@kwin Thanks, is there anything else to be done?
|
@kwin Could you please merge this PR - or is there anything outstanding? |
kwin
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #3401