feat: add xk to phone data #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be great help, great job @alekangelov 🚀🚀 |
DionIslami1
approved these changes
Jun 13, 2024
|
@alekangelov hello, please provide docs / website / wiki showing that Kosovo's mobile phone number format, thanks |
|
@Bossa573 Should I add as comment in code or just reference here? Cheers |
|
added references to code as well cheers |
|
@alekangelov the code is optional though. adding in github ticket is enough, coz it's only for manual reviewing |
|
just in case 👍 |
Bossa573
approved these changes
Jun 13, 2024
Bossa573
added a commit
that referenced
this pull request
Jun 13, 2024
- #386 Add Kosovo phone number format
|
sick cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, Kosovo is missing from the phone data, I added it + added a test for it. They have 6 mobile prefixes and the length of their mobile numbers is 8.
sources:
https://www.howtocallabroad.com/kosovo/
https://en.wikipedia.org/wiki/Telephone_numbers_in_Kosovo
The number format is 04x xxx xxx which is 8 digits.
Cheers