Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ratio Math page partially rendering #1204

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

mujahidkay
Copy link
Member

@mujahidkay mujahidkay commented Sep 11, 2024

Closes: #1183

Description

Fixes Ratio Math page's rendering issues due to hydration. The root cause turned out to be how BigInts were being translated to html code when written in non-codeblock form.

Also fixes some cases where there were no matching closes braces/parentheses.

Changes

Before

Screen.Recording.2024-09-11.at.6.47.20.PM.mov

After

Screen.Recording.2024-09-11.at.6.47.57.PM.mov

Copy link

cloudflare-workers-and-pages bot commented Sep 11, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d181e4
Status: ✅  Deploy successful!
Preview URL: https://b4d214e8.documentation-7tp.pages.dev
Branch Preview URL: https://ratio-math-hydration-debug.documentation-7tp.pages.dev

View logs

Copy link

github-actions bot commented Sep 11, 2024

Cloudflare deployment logs are available here

@mujahidkay mujahidkay changed the title debugging ratio math hydration error fix: Ratio Math page partially rendering Sep 11, 2024
@mujahidkay mujahidkay marked this pull request as ready for review September 11, 2024 13:55
@mujahidkay mujahidkay self-assigned this Sep 11, 2024
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to get rid of these rendering bugs.

Meanwhile, manually maintaining these function signatures is something we'd like to move away from. See:

@mujahidkay mujahidkay merged commit 47e40bc into main Sep 11, 2024
4 of 5 checks passed
@mujahidkay mujahidkay deleted the ratio-math-hydration-debug branch September 11, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issues rendering "ratio math" documentation page
2 participants