Skip to content

Commit

Permalink
Temporarily disable checking IPv6 BGP routing on neighbors for warm-r…
Browse files Browse the repository at this point in the history
…eboot (sonic-net#8735)

* Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot

Due to sonic-net/sonic-buildimage#12853, IPv6 BGP is partially broken,
where some IPv6 BGP prefixes aren't advertised up to T1 neighbors. In an
effort to get the warm reboot PR checker re-enabled, disable checking
the IPv6 BGP routing for now.

Once that PR is either fixed or reverted, revert this PR.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Add todo comment

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

---------

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
  • Loading branch information
saiarcot895 authored Jun 28, 2023
1 parent e872825 commit ff4bbf3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion ansible/roles/test/files/ptftests/arista.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,10 @@ def run(self):
'interfaces']['Port-Channel1']['lastStatusChangeTimestamp']
samples[cur_time] = sample

while not (quit_enabled and v4_routing_ok and v6_routing_ok):
# TODO: Disabling v6_routing_ok check due to IPv6 FRR issue. Re-add v6_routing_ok once either:
# * https://github.com/FRRouting/frr/issues/13587 is fixed and the fix gets merged into SONiC, or
# * https://github.com/sonic-net/sonic-buildimage/pull/12853 is reverted
while not (quit_enabled and v4_routing_ok):
cmd = None
# quit command was received, we don't process next commands
# but wait for v4_routing_ok and v6_routing_ok
Expand Down
5 changes: 4 additions & 1 deletion ansible/roles/test/files/ptftests/sonic.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ def run(self):
lacp_thread.setDaemon(True)
lacp_thread.start()

while not (quit_enabled and v4_routing_ok and v6_routing_ok):
# TODO: Disabling v6_routing_ok check due to IPv6 FRR issue. Re-add v6_routing_ok once either:
# * https://github.com/FRRouting/frr/issues/13587 is fixed and the fix gets merged into SONiC, or
# * https://github.com/sonic-net/sonic-buildimage/pull/12853 is reverted
while not (quit_enabled and v4_routing_ok):
cmd = None
# quit command was received, we don't process next commands
# but wait for v4_routing_ok and v6_routing_ok
Expand Down

0 comments on commit ff4bbf3

Please sign in to comment.