Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for #3870 #3880

Merged

Conversation

DedeHai
Copy link
Collaborator

@DedeHai DedeHai commented Apr 5, 2024

No description provided.

millis()/1000 rollover after 18h was not handled, truncating to 16bits after division fixes it.
@blazoncek blazoncek changed the base branch from main to 0_15 April 5, 2024 06:57
@blazoncek blazoncek linked an issue Apr 5, 2024 that may be closed by this pull request
1 task
Copy link
Collaborator

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An explicit cast goes a long way towards readable code. 😉

wled00/FX_fcn.cpp Outdated Show resolved Hide resolved
wled00/FX_fcn.cpp Outdated Show resolved Hide resolved
@blazoncek blazoncek merged commit 1cafa0b into Aircoookie:0_15 Apr 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plasma effect on random palet devolves into flickering chaos
2 participants