Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #3884 #3887

Merged
merged 1 commit into from
Apr 6, 2024
Merged

fix for #3884 #3887

merged 1 commit into from
Apr 6, 2024

Conversation

gaaat98
Copy link

@gaaat98 gaaat98 commented Apr 6, 2024

That 0.5f offset causes pwmBri to never be 0 even if _bri is set to 0 so the led won't turn off completely. Removing it fixes #3884.

@blazoncek blazoncek merged commit d18f078 into Aircoookie:0_15 Apr 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants